[asterisk-dev] [Code Review] Review directed pickup test using TestCase class

[Paul Belanger]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1401/#review4178
-----------------------------------------------------------



asterisk/trunk/tests/directed_pickup/run-test
<https://reviewboard.asterisk.org/r/1401/#comment8219>

    This is a callback function for the 'Bridge' event, making sure the first and second channels are actually bridged.
    
    However, something odd I noticed, the event is call multiple times (25 to 35 times).  I can't figure out why, but this data just floods the AMI connection.  
    
    We only care about the first one, so increment the counter and ignore the rest.  But I think somebody should see what is going on.


- Paul


On Aug. 30, 2011, 8:05 a.m., Paul Belanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1401/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2011, 8:05 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Directed pickup is failing under FreeBSD, so I decided to look at it and then rewrite it.  It now uses the TestCase class allowing us to inherit the python logging class. The test now monitor AMI events, to confirm the directed pickup happens, rather then timing.
> 
> 
> Diffs
> -----
> 
>   asterisk/trunk/tests/directed_pickup/configs/ast1/extensions.conf 1972 
>   asterisk/trunk/tests/directed_pickup/run-test 1972 
> 
> Diff: https://reviewboard.asterisk.org/r/1401/diff
> 
> 
> Testing
> -------
> 
> local development box
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110830/d792c452/attachment.htm>