[asterisk-dev] [Code Review]: Some cleanups for the recently commited T38 Gw timeout option

[irroot]

> On Aug. 29, 2011, 8:52 a.m., Matthew Nicholson wrote:
> > /branches/10/res/res_fax.c, line 2426
> > <https://reviewboard.asterisk.org/r/1385/diff/1/?file=19205#file19205line2426>
> >
> >     This is here so that when a gateway_timeout is set, a session is reserved. If the timeout is disabled, then no session will be reserved.

gwtimeout = no sets this to 0 ??


> On Aug. 29, 2011, 8:52 a.m., Matthew Nicholson wrote:
> > /branches/10/res/res_fax.c, line 2907
> > <https://reviewboard.asterisk.org/r/1385/diff/1/?file=19205#file19205line2907>
> >
> >     If timeout_start is set then gateway_timeout will also be set. I guess it doesn't hurt to check both.

it seems see above that it also started elsewhere so i let it start the timer as it may be needed for future use


> On Aug. 29, 2011, 8:52 a.m., Matthew Nicholson wrote:
> > /branches/10/res/res_fax.c, lines 2885-2887
> > <https://reviewboard.asterisk.org/r/1385/diff/1/?file=19205#file19205line2885>
> >
> >     timeout_start only needs to be set when the timeout is enabled. A timeout value of 0 indicates that no timeout is enabled.

gwtimeout = no is 0 other places start the timeout this could lead to confusion latter.

see below this could be used in cli status of session.


> On Aug. 29, 2011, 8:52 a.m., Matthew Nicholson wrote:
> > /branches/10/res/res_fax.c, line 2510
> > <https://reviewboard.asterisk.org/r/1385/diff/1/?file=19205#file19205line2510>
> >
> >     The timeout defaults to 10 seconds.

This is set when details are allocated and dont need to be set again the default will be this 10s see session_details_new

we reseting the timer to the default each time ??

Same as bellow


- irroot


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1385/#review4159
-----------------------------------------------------------


On Aug. 29, 2011, 8:30 a.m., irroot wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1385/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2011, 8:30 a.m.)
> 
> 
> Review request for Asterisk Developers and Matthew Nicholson.
> 
> 
> Summary
> -------
> 
> Recent Changes to res_fax.c to support configurable timeout is not optimal here is a fixup.
> 
> 
> This addresses bug ASTERISK-18219.
>     https://issues.asterisk.org/jira/browse/ASTERISK-18219
> 
> 
> Diffs
> -----
> 
>   /branches/10/res/res_fax.c 333337 
> 
> Diff: https://reviewboard.asterisk.org/r/1385/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> irroot
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110829/a947d52b/attachment-0001.htm>