[asterisk-dev] [Code Review] Some cleanups for the recently commited T38 Gw timeout option

[Matthew Nicholson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1385/#review4159
-----------------------------------------------------------



/branches/10/res/res_fax.c
<https://reviewboard.asterisk.org/r/1385/#comment8165>

    This is here so that when a gateway_timeout is set, a session is reserved. If the timeout is disabled, then no session will be reserved.



/branches/10/res/res_fax.c
<https://reviewboard.asterisk.org/r/1385/#comment8168>

    The timeout defaults to 10 seconds.



/branches/10/res/res_fax.c
<https://reviewboard.asterisk.org/r/1385/#comment8166>

    We need a timeout around T.38 negotiation.



/branches/10/res/res_fax.c
<https://reviewboard.asterisk.org/r/1385/#comment8167>

    T.38 negotiation.



/branches/10/res/res_fax.c
<https://reviewboard.asterisk.org/r/1385/#comment8170>

    timeout_start only needs to be set when the timeout is enabled. A timeout value of 0 indicates that no timeout is enabled.



/branches/10/res/res_fax.c
<https://reviewboard.asterisk.org/r/1385/#comment8171>

    If timeout_start is set then gateway_timeout will also be set. I guess it doesn't hurt to check both.


- Matthew


On Aug. 29, 2011, 8:30 a.m., irroot wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1385/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2011, 8:30 a.m.)
> 
> 
> Review request for Asterisk Developers and Matthew Nicholson.
> 
> 
> Summary
> -------
> 
> Recent Changes to res_fax.c to support configurable timeout is not optimal here is a fixup.
> 
> 
> This addresses bug ASTERISK-18219.
>     https://issues.asterisk.org/jira/browse/ASTERISK-18219
> 
> 
> Diffs
> -----
> 
>   /branches/10/res/res_fax.c 333337 
> 
> Diff: https://reviewboard.asterisk.org/r/1385/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> irroot
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110829/aea4466d/attachment-0001.htm>