[asterisk-dev] [Code Review] Dial d and H option break DTMF attended transfer atxferdropcall option.

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1381/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

Dial d and H option break DTMF attended transfer atxferdropcall option.

1) Party A calls party B.
2) Party B does a DTMF attended transfer to Party C.

If the dialplan uses the Dial d or H option to call Party C then the Dial
application answers the call immediately before initiating the call leg to
Party C.  The premature answer causes the transfer code to not invoke the
atxferdropcall=no behavior for a blonde transfer since Party C has
"answered".  The transfer code thinks that Party B has "consulted" with
Party C when Party B hangs up and completes the transfer to Party A.
Party A now hears ringback until Party C actually answers.

ASTERISK-13294 Dial d option.
ASTERISK-11067 Dial H option to disconnect before answer.

The referenced issues made Dial answer with the d and H options because
many SIP and ISDN phones cannot send DTMF before the call is connected.

* Made require the dialplan to control when or if the call needs to be
answered to use the Dial application d and H options.  (The call is no
longer surprise answered when using the Dial d or H options.)

JIRA AST-623


This addresses bug AST-623.
    https://issues.asterisk.org/jira/browse/AST-623


Diffs
-----

  /branches/1.8/apps/app_dial.c 333263 
  /branches/1.8/UPGRADE.txt 333263 

Diff: https://reviewboard.asterisk.org/r/1381/diff


Testing
-------

Did a blonde transfer and Party A no longer hears MOH switch to ringpack when Party B hangs up if Dial has a d or H option.
atxferdropcall=no now works as intended.


Thanks,

rmudgett

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110825/0ccd8b2e/attachment.htm>