[asterisk-dev] [Code Review] TestSuite updates for VoiceMailMain, logging functionality

[mjordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1380/
-----------------------------------------------------------

(Updated Aug. 25, 2011, 1:12 p.m.)


Review request for Asterisk Developers, Matthew Nicholson and Paul Belanger.


Changes
-------

Updated to show only utility and logging changes.  VoiceMailMain tests will be reviewed later.


Summary (updated)
-------

This update adds a large number of tests to cover checking voicemails through app_voicemail's VoiceMailMain.  It supersedes review 1363, as it includes the single test that was used to prove the TestEvent concept (https://reviewboard.asterisk.org/r/1363/).

This review also includes the addition of python logging.  At the time of debugging and verifying these tests, it appeared as if its inclusion was necessary to resolve some outstanding issues - as it turned out, this may not have been the case.  As including logging was a desired goal, it was left in and included in this review package.  Note that the test output for tests that do not support python logging has been changed to 'test-console-output.txt', to avoid file collisions with the test cases that do support python logging.

[Edit] - this review has now been updated to only have the logging and the necessary utility classes to support the VoiceMailMain tests.


Diffs (updated)
-----

  /asterisk/trunk/tests/directed_pickup/run-test 1911 
  /asterisk/trunk/tests/udptl_v6/run-test 1911 
  /asterisk/trunk/tests/pbx/call-files/run-test 1911 
  /asterisk/trunk/tests/fastagi/get-data/run-test 1911 
  /asterisk/trunk/tests/fastagi/hangup/run-test 1911 
  /asterisk/trunk/tests/fastagi/record-file/run-test 1911 
  /asterisk/trunk/tests/fastagi/say-alpha/run-test 1911 
  /asterisk/trunk/tests/fastagi/say-date/run-test 1911 
  /asterisk/trunk/tests/fastagi/say-datetime/run-test 1911 
  /asterisk/trunk/tests/fastagi/say-digits/run-test 1911 
  /asterisk/trunk/tests/fastagi/say-number/run-test 1911 
  /asterisk/trunk/tests/fastagi/say-phonetic/run-test 1911 
  /asterisk/trunk/tests/fastagi/say-time/run-test 1911 
  /asterisk/trunk/tests/fastagi/wait-for-digit/run-test 1911 
  /asterisk/trunk/tests/feature_attended_transfer/run-test 1911 
  /asterisk/trunk/tests/feature_blonde_transfer/run-test 1911 
  /asterisk/trunk/tests/iax2/basic-call/run-test 1911 
  /asterisk/trunk/tests/manager/event-monitor/run-test 1911 
  /asterisk/trunk/tests/mixmonitor/run-test 1911 
  /asterisk/trunk/tests/mixmonitor_audiohook_inherit/run-test 1911 
  /asterisk/trunk/tests/one-step-parking/run-test 1911 
  /asterisk/trunk/tests/fastagi/execute/run-test 1911 
  /asterisk/trunk/tests/chanspy/chanspy_barge/run-test 1911 
  /asterisk/trunk/tests/chanspy/chanspy_w_mixmonitor/run-test 1911 
  /asterisk/trunk/tests/channels/SIP/sip_register/run-test 1911 
  /asterisk/trunk/tests/channels/SIP/sip_one_legged_transfer_v6/run-test 1911 
  /asterisk/trunk/tests/channels/SIP/sip_one_legged_transfer/run-test 1911 
  /asterisk/trunk/tests/channels/SIP/sip_attended_transfer_tcp/run-test 1911 
  /asterisk/trunk/tests/channels/SIP/sip_attended_transfer_v6/run-test 1911 
  /asterisk/trunk/tests/channels/SIP/sip_attended_transfer/run-test 1911 
  /asterisk/trunk/tests/blind-transfer-parkingtimeout/run-test 1911 
  /asterisk/trunk/tests/apps/voicemail/tests.yaml 1911 
  /asterisk/trunk/tests/apps/voicemail/leave_voicemail_nominal/configs/ast2/extensions.conf 1911 
  /asterisk/trunk/runtests.py 1911 
  /asterisk/trunk/lib/python/asterisk/voicemail.py 1911 
  /asterisk/trunk/lib/python/asterisk/version.py 1911 
  /asterisk/trunk/lib/python/asterisk/sipp.py 1911 
  /asterisk/trunk/lib/python/asterisk/config.py 1911 
  /asterisk/trunk/lib/python/asterisk/cdr.py 1911 
  /asterisk/trunk/lib/python/asterisk/TestState.py PRE-CREATION 
  /asterisk/trunk/lib/python/asterisk/ami.py 1911 
  /asterisk/trunk/lib/python/asterisk/asterisk.py 1911 
  /asterisk/trunk/asttest/asttest.c 1911 
  /asterisk/trunk/lib/python/asterisk/TestCase.py 1911 

Diff: https://reviewboard.asterisk.org/r/1380/diff


Testing
-------

Each new test was tested independently and as a whole with the other tests in the testsuite.  No failures were observed that were caused by adding new logging functionality or from the new tests.


Thanks,

mjordan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110825/b6a709f4/attachment.htm>