[asterisk-dev] [Code Review] Meetme option: Drop conference when only one participant remains at exit

opticron reviewboard at asterisk.org
Tue Aug 23 11:09:30 CDT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1376/#review4109
-----------------------------------------------------------

Ship it!



/trunk/apps/app_meetme.c
<https://reviewboard.asterisk.org/r/1376/#comment8055>

    Might as well fix the blob since it's directly adjacent to changed code.



/trunk/apps/app_meetme.c
<https://reviewboard.asterisk.org/r/1376/#comment8056>

    Blob


The patch looks good other than the blobs.

- opticron


On Aug. 23, 2011, 7:53 a.m., Olle E Johansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1376/
> -----------------------------------------------------------
> 
> (Updated Aug. 23, 2011, 7:53 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch adds a new option - "k" - to meetme(). When this is effective, meetme checks if there's only one user left at exit. If that's the case, the conference is closed and the remaining user kicked out. This is very handy when using meetme as a "normal" call bridge.
> 
> 
> This addresses bug ASTERISK-18324.
>     https://issues.asterisk.org/jira/browse/ASTERISK-18324
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 332755 
>   /trunk/CREDITS 332755 
>   /trunk/apps/app_meetme.c 332755 
> 
> Diff: https://reviewboard.asterisk.org/r/1376/diff
> 
> 
> Testing
> -------
> 
> The 1.4 version of this patch has been used in production during the summer.
> 
> 
> Thanks,
> 
> Olle E
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110823/a7b90382/attachment.htm>


More information about the asterisk-dev mailing list