[asterisk-dev] [Code Review]: Generate security events in chan_sip using new Security Events Framework

[elguero]

> On Aug. 12, 2011, 8:19 a.m., Paul Belanger wrote:
> > /branches/10/channels/chan_sip.c, lines 1634-1639
> > <https://reviewboard.asterisk.org/r/1362/diff/1/?file=18288#file18288line1634>
> >
> >     remove 1 level of indent

Fixed.


> On Aug. 12, 2011, 8:19 a.m., Paul Belanger wrote:
> > /branches/10/channels/chan_sip.c, line 1632
> > <https://reviewboard.asterisk.org/r/1362/diff/1/?file=18288#file18288line1632>
> >
> >     space between h and (

Fixed.


- elguero


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1362/#review4046
-----------------------------------------------------------


On Aug. 12, 2011, 1:07 a.m., elguero wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1362/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2011, 1:07 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Security Events Framework was added in 1.8 and support was added for AMI to generate events at that time.
> 
> This patch attempts to add support in chan_sip to generate security events.  Hopefully we can get this into Asterisk 10.
> 
> I am looking forward to hearing feedback on where this patch can be improved especially from those who have an intimate knowledge of chan_sip.
> 
> Thanks
> 
> 
> This addresses bug 18264.
>     https://issues.asterisk.org/jira/browse/18264
> 
> 
> Diffs
> -----
> 
>   /branches/10/channels/chan_sip.c 331633 
>   /branches/10/configs/logger.conf.sample 331633 
>   /branches/10/CHANGES 331633 
> 
> Diff: https://reviewboard.asterisk.org/r/1362/diff
> 
> 
> Testing
> -------
> 
> Local dev machine and a softphone.  Generated events by using the wrong username, wrong password, wrong auth name, successful authentication.
> 
> 
> Thanks,
> 
> elguero
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110812/f731e3e3/attachment-0001.htm>