[asterisk-dev] [Code Review] Allow ENUM query functions to report lookup errors

opticron reviewboard at asterisk.org
Tue Aug 9 12:02:18 CDT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1355/
-----------------------------------------------------------

(Updated Aug. 9, 2011, 12:02 p.m.)


Review request for Asterisk Developers.


Changes
-------

Cleaned up some debugging in the patch and some whitespace issues.


Summary
-------

The ENUM dialplan functions do not report DNS query errors properly. It is useful to differentiate between failed query (e.g. non-existent domain) vs. no data records of the appropriate type. This is required to make overlapped dialing work.


This addresses bug ASTERISK-13769.
    https://issues.asterisk.org/jira/browse/ASTERISK-13769


Diffs (updated)
-----

  trunk/main/enum.c 331136 
  trunk/UPGRADE.txt 331136 
  trunk/funcs/func_enum.c 331136 

Diff: https://reviewboard.asterisk.org/r/1355/diff


Testing
-------

Tested number lookups with multiple results, 1 result, 0 results, and lookup failures.


Thanks,

opticron

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110809/81c03467/attachment.htm>


More information about the asterisk-dev mailing list