[asterisk-dev] [Code Review]: Allow ENUM query functions to report lookup errors

[opticron]

> On Aug. 9, 2011, 9:58 a.m., jrose wrote:
> > trunk/main/enum.c, lines 861-865
> > <https://reviewboard.asterisk.org/r/1355/diff/1/?file=17803#file17803line861>
> >
> >     It looks like these are spaces followed by tabs for some reason.  Fix that.

Done.


> On Aug. 9, 2011, 9:58 a.m., jrose wrote:
> > trunk/main/enum.c, lines 854-855
> > <https://reviewboard.asterisk.org/r/1355/diff/1/?file=17803#file17803line854>
> >
> >     I assume that this is where you are differentiating between the different kinds of failures.  Any chance of getting this represented in a string form like it was before instead of with a number?  We generally like stuff like this to be represented in a readable form.
> 
> jrose wrote:
>     By differentiating, I mean for the purpose of readable output just to clarify.  I see that it's actually a combination of this and what's below.  Actually, it's probably better to get it done in fewer debug statements if you can, since this is all really relating to a single function's issue.

Looking at this block, it appears a lot of this code was added or changed for debugging purposes in the initial patch.  I'm minimizing the change in this block to the one-line addition that is necessary for the proper functionality.


- opticron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1355/#review4003
-----------------------------------------------------------


On Aug. 9, 2011, 9:30 a.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1355/
> -----------------------------------------------------------
> 
> (Updated Aug. 9, 2011, 9:30 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> The ENUM dialplan functions do not report DNS query errors properly. It is useful to differentiate between failed query (e.g. non-existent domain) vs. no data records of the appropriate type. This is required to make overlapped dialing work.
> 
> 
> This addresses bug ASTERISK-13769.
>     https://issues.asterisk.org/jira/browse/ASTERISK-13769
> 
> 
> Diffs
> -----
> 
>   trunk/UPGRADE.txt 330825 
>   trunk/funcs/func_enum.c 330825 
>   trunk/main/enum.c 330825 
> 
> Diff: https://reviewboard.asterisk.org/r/1355/diff
> 
> 
> Testing
> -------
> 
> Tested number lookups with multiple results, 1 result, 0 results, and lookup failures.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110809/2b7f305d/attachment.htm>