[asterisk-dev] [Code Review] Call pickup broken for DAHDI channels when beginning with #

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1336/#review3972
-----------------------------------------------------------



trunk/channels/sig_analog.h
<https://reviewboard.asterisk.org/r/1336/#comment7814>

    As a FYI, sig_analog public identifiers are prefixed with analog_ or ANALOG_.



trunk/channels/sig_analog.c
<https://reviewboard.asterisk.org/r/1336/#comment7813>

    Extra space after *.
    
    This should be a static function in sig_analog.c and duplicated in chan_dahdi.c.  It is a helper function that is very specific to where it is called.
    
    This is not the only function that is duplicated between sig_analog.c and chan_dahdi.c.  See attempt_transfer() in chan_dahdi.c and analog_attemp_transfer() in sig_analog.c.
    
    Also the function in sig_analog.c should be called analog_canmatch_featurecode().  In chan_dahdi.c it can be simply called canmatch_featurecode().



trunk/channels/sig_analog.c
<https://reviewboard.asterisk.org/r/1336/#comment7816>

    To be paranoid about such things, an extlen of zero should return 1.



trunk/channels/sig_analog.c
<https://reviewboard.asterisk.org/r/1336/#comment7815>

    extlen < 2 since if it is 3 it should have matched already.


- rmudgett


On Aug. 2, 2011, 1:59 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1336/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2011, 1:59 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> The call pickup feature did not work on DAHDI devices for anything other than feature codes beginning with * since all feature codes in chan_dahdi were originally hard-coded to begin with *.  This patch is also applied to chan_dahdi.c to fix this bug with GR.303.
> 
> 
> This addresses bug AST-621.
>     https://issues.asterisk.org/jira/browse/AST-621
> 
> 
> Diffs
> -----
> 
>   trunk/channels/chan_dahdi.c 330488 
>   trunk/channels/sig_analog.h 330488 
>   trunk/channels/sig_analog.c 330488 
> 
> Diff: https://reviewboard.asterisk.org/r/1336/diff
> 
> 
> Testing
> -------
> 
> Verified bug with TDM410P.  Tested patch with various call pickup feature codes beginning with * and #.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110802/062422a8/attachment.htm>