[asterisk-dev] [Code Review] Call pickup broken for DAHDI channels when beginning with #

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1336/
-----------------------------------------------------------

(Updated Aug. 2, 2011, 1:59 p.m.)


Review request for Asterisk Developers.


Changes
-------

Be more precise in validation of possible feature code matches.  Addresses code duplicated for radio modes as well.


Summary
-------

The call pickup feature did not work on DAHDI devices for anything other than feature codes beginning with * since all feature codes in chan_dahdi were originally hard-coded to begin with *.  This patch is also applied to chan_dahdi.c to fix this bug with GR.303.


This addresses bug AST-621.
    https://issues.asterisk.org/jira/browse/AST-621


Diffs (updated)
-----

  trunk/channels/chan_dahdi.c 330488 
  trunk/channels/sig_analog.h 330488 
  trunk/channels/sig_analog.c 330488 

Diff: https://reviewboard.asterisk.org/r/1336/diff


Testing
-------

Verified bug with TDM410P.  Tested patch with various call pickup feature codes beginning with * and #.


Thanks,

opticron

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110802/048bed86/attachment.htm>