[asterisk-dev] [Code Review] Changes to h323 to allow use with h323plus > 1.20.

Paul Belanger reviewboard at asterisk.org
Wed Apr 27 09:56:23 CDT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1117/#review3443
-----------------------------------------------------------


I missed a few last time around.


/trunk/channels/chan_h323.c
<https://reviewboard.asterisk.org/r/1117/#comment7077>

    space between switch and (



/trunk/channels/chan_h323.c
<https://reviewboard.asterisk.org/r/1117/#comment7078>

    break; for consistency?



/trunk/channels/h323/ast_h323.cxx
<https://reviewboard.asterisk.org/r/1117/#comment7079>

    remove the space between ! and h



/trunk/channels/h323/ast_h323.cxx
<https://reviewboard.asterisk.org/r/1117/#comment7080>

    Decelerations at beginning of code block


- Paul


On 2011-04-27 04:59:57, irroot wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1117/
> -----------------------------------------------------------
> 
> (Updated 2011-04-27 04:59:57)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Changes to h323 to allow use with h323plus > 1.20.
> 
> 
> This addresses bugs 16619 and 18670.
>     https://issues.asterisk.org/view.php?id=16619
>     https://issues.asterisk.org/view.php?id=18670
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_h323.c 315724 
>   /trunk/channels/h323/ast_h323.h 315724 
>   /trunk/channels/h323/ast_h323.cxx 315724 
>   /trunk/channels/h323/chan_h323.h 315724 
>   /trunk/configs/h323.conf.sample 315724 
>   /trunk/configure.ac 315724 
> 
> Diff: https://reviewboard.asterisk.org/r/1117/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> irroot
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110427/7712d291/attachment-0001.htm>


More information about the asterisk-dev mailing list