[asterisk-dev] [Code Review] Use port returned by dns_lookup when transmitting sip REGISTER

[David Vossel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1179/#review3330
-----------------------------------------------------------



/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/1179/#comment6925>

    This fixed the problem we encountered earlier, but because the return code from ast_dnsmgr_lookup does not return if the initial lookup returns a record or not, this approach is not reliable.  More thought must be put into this patch.


- David


On 2011-04-13 11:25:28, David Vossel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1179/
> -----------------------------------------------------------
> 
> (Updated 2011-04-13 11:25:28)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> If dnsmanager is not enabled, dsn lookups still occur for outgoing sip REGISTERs but are just not updated in the background.  The logic in transmit_register() assumes that if no dns object is allocated no dns lookup occurred and writes over the port number.  This incorrect.
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_sip.c 313187 
> 
> Diff: https://reviewboard.asterisk.org/r/1179/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110413/a2bfe712/attachment.htm>