[asterisk-dev] [Code Review] Use port returned by dns_lookup when transmitting sip REGISTER
David Vossel
reviewboard at asterisk.org
Wed Apr 13 11:25:28 CDT 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1179/
-----------------------------------------------------------
Review request for Asterisk Developers.
Summary
-------
If dnsmanager is not enabled, dsn lookups still occur for outgoing sip REGISTERs but are just not updated in the background. The logic in transmit_register() assumes that if no dns object is allocated no dns lookup occurred and writes over the port number. This incorrect.
Diffs
-----
/trunk/channels/chan_sip.c 313187
Diff: https://reviewboard.asterisk.org/r/1179/diff
Testing
-------
Thanks,
David
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110413/cbc4e6d3/attachment.htm>
More information about the asterisk-dev
mailing list