[asterisk-dev] [Code Review] "dahdi show channels group" auto-completion bug

[jrose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1168/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

Tab completion Bug - "dahdi show channels group" continuously adds the word group to the end as you hit tab repeatedly.

Removed a function more_words from cli.c and removed its use as a conditional for terminating the while loop looking through completion since it seems like it's redundant with the already existing for loop iterating through the existing words.  I'm not sure though.


This addresses bug 17494.
    https://issues.asterisk.org/view.php?id=17494


Diffs
-----

  /branches/1.6.2/main/cli.c 313189 

Diff: https://reviewboard.asterisk.org/r/1168/diff


Testing
-------

Tested patch using dozens of cli commands with a variety of tab completion combinations to make sure it wasn't breaking.  Tested the actual command in question as well of course to make sure it didn't repeat.


Thanks,

jrose

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110411/11e5b632/attachment.htm>