[asterisk-dev] [Code Review] handle_request_subscribe is too slow cause of iterating through all sip dialogs

Olle E. Johansson oej at edvina.net
Fri Sep 3 08:21:15 CDT 2010


3 sep 2010 kl. 14.23 skrev Russell Bryant:

> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/901/#review2662
> -----------------------------------------------------------
> 
> Ship it!
> 
> 
> Wow, I'm surprised this code was in there.  I agree - make it go away!
Like I said in the IRC channel - remove it quickly and let's forget all about it... 

/O
> 
> - Russell
> 
> 
> On 2010-09-03 07:08:29, schmidts wrote:
>> 
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviewboard.asterisk.org/r/901/
>> -----------------------------------------------------------
>> 
>> (Updated 2010-09-03 07:08:29)
>> 
>> 
>> Review request for Asterisk Developers.
>> 
>> 
>> Summary
>> -------
>> 
>> in chan_sip.c the handle_request_subscribe function is very slow cause of iterating through all sip dialogs on every subscribe, to find old subscribes from this peer to exten at context. This patch will disable this iteration cause its not necessary.
>> 
>> 
>> Diffs
>> -----
>> 
>>  branches/1.6.2/channels/chan_sip.c 284848 
>> 
>> Diff: https://reviewboard.asterisk.org/r/901/diff
>> 
>> 
>> Testing
>> -------
>> 
>> 
>> Thanks,
>> 
>> schmidts
>> 
>> 
> 
> 
> -- 
> _____________________________________________________________________
> -- Bandwidth and Colocation Provided by http://www.api-digital.com --
> 
> asterisk-dev mailing list
> To UNSUBSCRIBE or update options visit:
>   http://lists.digium.com/mailman/listinfo/asterisk-dev

---
* Olle E Johansson - oej at edvina.net
* Cell phone +46 70 593 68 51, Office +46 8 96 40 20, Sweden






More information about the asterisk-dev mailing list