[asterisk-dev] [Code Review] handle_request_subscribe is too slow cause of iterating through all sip dialogs

Russell Bryant russell at digium.com
Fri Sep 3 07:23:58 CDT 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/901/#review2662
-----------------------------------------------------------

Ship it!


Wow, I'm surprised this code was in there.  I agree - make it go away!

- Russell


On 2010-09-03 07:08:29, schmidts wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/901/
> -----------------------------------------------------------
> 
> (Updated 2010-09-03 07:08:29)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> in chan_sip.c the handle_request_subscribe function is very slow cause of iterating through all sip dialogs on every subscribe, to find old subscribes from this peer to exten at context. This patch will disable this iteration cause its not necessary.
> 
> 
> Diffs
> -----
> 
>   branches/1.6.2/channels/chan_sip.c 284848 
> 
> Diff: https://reviewboard.asterisk.org/r/901/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> schmidts
> 
>




More information about the asterisk-dev mailing list