[asterisk-dev] [Code Review] Base directory for MOH should be ASTDATADIR

[Tzafrir Cohen]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/974/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

Originally, the directive 'directory' in musiconhold.conf had to use a full path. in r149917 support for relative paths (relative to astvarlibdir, which defaults to /var/lib/asterisk).

However, if one sets ASTDATADIR to a different value at build time, the MOH files will be installed under that directory (see sounds/Makefile). 

Also, in that case, and also in the case where you set astdatadir in asterisk.conf, the sounds directory resides under the datadir. It would be surprising that the MOH directory doesn't.

Issue 16906 has a trivial patch to fix that. This patch (or something similar) is required to make the Debian and Ubuntu packages work well with the default musiconhold.conf of asterisk. By now it has already been included in two releases of Ubuntu and will probably soon be squeezed into a Debian release.

Any feedback?


This addresses bug https://issues.asterisk.org/view.php?id=16906.
    https://issues.asterisk.org/view.php?id=https://issues.asterisk.org/view.php?id=16906


Diffs
-----

  /trunk/res/res_musiconhold.c 291760 

Diff: https://reviewboard.asterisk.org/r/974/diff


Testing
-------


Thanks,

Tzafrir