[asterisk-dev] ast_app_dtget inconsistency?

[Leif Madsen]

On 10-10-11 07:08 PM, Dmitry Andrianov wrote:
> Hi.
>
> I noticed strange thing in the code decided to share. 1.6.2.13,
> main/app.c, ast_app_dtget function at the very beginning it tries to
> configure the timeout unless it is specified:
>
> if (!timeout && chan->pbx) {
>
> timeout = chan->pbx->dtimeoutms / 1000.0;
>
> } else if (!timeout) {
>
> timeout = 5;
>
> }
>
> Both branches indicate the final value for timeout is in seconds.
> However I believe ast_waitfordigit accepts timeout in milliseconds.
>
> And as I see when ast_app_dtget is called by builtin_atxfer, the timeout
> passed is also in ms. So I guess the code above may be wrong.

Please open an issue for this so it can be triaged. Unless someone just happens 
to look at this and want to fix it immediately, it will get lost forever.

Leif.