[asterisk-dev] [Code Review] adding CLI function sip show dialogs

[sst at sil.at]

> On 2010-10-12 20:35:59, Jeff Peeler wrote:
> > trunk/channels/chan_sip.c, line 15812
> > <https://reviewboard.asterisk.org/r/966/diff/2/?file=12683#file12683line15812>
> >
> >     Here and below, shouldn't this be passing flags instead of just 0?

good point. After looking to flags i understand why its only a 0 here but this should be fixed ;) 
The problem is there a 3 different flags used for a dialog. i could print out all 3 unsigned int values but i am not sure if this really would help and i havent found a function which creates a nice output for flags. is there allready something like flag2str?


- schmidts


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/966/#review2826
-----------------------------------------------------------


On 2010-10-06 04:02:22, schmidts wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/966/
> -----------------------------------------------------------
> 
> (Updated 2010-10-06 04:02:22)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Using sip show objects to check sip dialogs is not very usefull and blocks the peer container unnecessary.
> 
> i have written this function sip show dialogs which checks the three container where dialogs could be included and just print them out.
> 
> 
> Diffs
> -----
> 
>   trunk/channels/chan_sip.c 290305 
> 
> Diff: https://reviewboard.asterisk.org/r/966/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> schmidts
> 
>