[asterisk-dev] [Code Review] adding CLI function sip show dialogs

sst at sil.at sst at sil.at
Wed Oct 6 04:02:22 CDT 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/966/
-----------------------------------------------------------

(Updated 2010-10-06 04:02:22.384775)


Review request for Asterisk Developers.


Changes
-------

Add check of --enable-dev-mode to enable this function only when configured with AST_DEVMODE enabled.
Removed iteration through all 3 Container and add checks if a dialog could exists in the other two container (needdestroy and rtpcheck).
With devmode enabled the output format of sip show objects would change to also show if a dialog exists in the other container too.

Changed name from sip show dialogs to sip show pvts as OEJ suggested, cause it really fit more into the structure.


Summary
-------

Using sip show objects to check sip dialogs is not very usefull and blocks the peer container unnecessary.

i have written this function sip show dialogs which checks the three container where dialogs could be included and just print them out.


Diffs (updated)
-----

  trunk/channels/chan_sip.c 290305 

Diff: https://reviewboard.asterisk.org/r/966/diff


Testing
-------


Thanks,

schmidts




More information about the asterisk-dev mailing list