[asterisk-dev] [Code Review] adding CLI function sip show dialogs

[David Vossel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/966/#review2807
-----------------------------------------------------------


All the dialogs will be in the main dialogs container until they are destroyed.  Could you not just loop through the ones in that container and then determine what other containers they are in as well.  You could have some sort of symbol next to each one that tells what containers it is currently in. That way a dialog is only presented once, drastically shortening the output.

- David


On 2010-10-05 10:21:47, schmidts wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/966/
> -----------------------------------------------------------
> 
> (Updated 2010-10-05 10:21:47)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Using sip show objects to check sip dialogs is not very usefull and blocks the peer container unnecessary.
> 
> i have written this function sip show dialogs which checks the three container where dialogs could be included and just print them out.
> 
> 
> Diffs
> -----
> 
>   trunk/channels/chan_sip.c 290305 
> 
> Diff: https://reviewboard.asterisk.org/r/966/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> schmidts
> 
>