[asterisk-dev] [Code Review] Hints and devices from hints moved to ao2_container

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1003/#review2977
-----------------------------------------------------------

Ship it!


These last comments are pretty minor.  After these changes, feel free to merge.  Excellent work!


branches/1.8/main/pbx.c
<https://reviewboard.asterisk.org/r/1003/#comment6199>

    It would be good to convert this comment to doxygen format.  Also, please convert your other comments to match the style of others with a '*' on each line:
    
    /*!
     * \brief
     *
     * ...
     */



branches/1.8/main/pbx.c
<https://reviewboard.asterisk.org/r/1003/#comment6200>

    I think for the sake of simplifying the code, I would remove the entire if block for the case that only a single device is specified.  Your code in the else block will handle that case, too.



branches/1.8/main/pbx.c
<https://reviewboard.asterisk.org/r/1003/#comment6203>

    No need to +1 here since you include it in the structure definition



branches/1.8/main/pbx.c
<https://reviewboard.asterisk.org/r/1003/#comment6202>

    No need to add +1 here since you include a byte for the trailing null character in the structure definition.



branches/1.8/main/pbx.c
<https://reviewboard.asterisk.org/r/1003/#comment6201>

    ast_malloc() will generate an ERROR for you on failure.


- Russell


On 2010-11-17 04:35:40, schmidts wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1003/
> -----------------------------------------------------------
> 
> (Updated 2010-11-17 04:35:40)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> handle_statechange in pbx.c has a very great impact on call handling performance. i have noticed this several times and i have written a solution which makes handle_statechange handling 61 times faster.
> 
> i have used the patch (rev. 293802 for 1.4) from russellb and jeffpeeler to also fix a deadlock problem and their part to move hints to an ao2_container.
> 
> after thinking about the best solution IMO iterating through the whole hint list/container to maybe find a hint with a matching device is very expensive way. So i have used a own container for devices which just have a link back to their hint. 
> This means there is a hashed cmp for devices which gives back a multiple object ao2_iterator for all hints, this device, which have a state change, is used in. 
> 
> these devices are not longer limited to any length so its possible to use a hint for 100 peers at once.
> 
> Tilghman Lesher noticed on the dev-list what would happen when a dynamic hint is used. I have tried this with one dynamic hint and subscribe up to 2500 different users on this, several times and it works just fine. If a subscribe for a dynamic hint comes in, a static extension with static appdata is generated which acts like a normal hint so there is no problem on this. 
> 
> 
> Diffs
> -----
> 
>   branches/1.8/main/pbx.c 295358 
> 
> Diff: https://reviewboard.asterisk.org/r/1003/diff
> 
> 
> Testing
> -------
> 
> dialplan reload drops all devices out of the device container and recreate them by their callback list.
> core show hint / hints show all hints also dynamic and their watchers
> 
> 
> loadtests shows the following result:
> 
> orig version: 
> handle_statechange COUNTER: 10009 overalltime: 7041 ms 
> MAX: 365 CPS
> 
> patched version:
> handle_statechange COUNTER: 10009 overalltime: 115 ms
> MAX: 580 CPS
> 
> same setup, same config tested with sipp.
> 
> 
> Thanks,
> 
> schmidts
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.digium.com/pipermail/asterisk-dev/attachments/20101129/41f1823d/attachment-0001.htm