[asterisk-dev] [Code Review] Global debug and verbose settings

[Russell Bryant]

> On 2010-11-21 00:16:41, Paul Belanger wrote:
> > asterisk/trunk/lib/python/asterisk/asterisk.py, lines 358-359
> > <https://reviewboard.asterisk.org/r/1026/diff/2/?file=13117#file13117line358>
> >
> >     Not sure if this is a bug or what, but a full path must be use for asterisk.conf otherwise Asterisk will not find the file to be #included.

It's not a bug.  Asterisk doesn't know what the configuration directory is supposed to be until after it has finished parsing asterisk.conf.


- Russell


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1026/#review2952
-----------------------------------------------------------


On 2010-11-21 11:41:39, Paul Belanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1026/
> -----------------------------------------------------------
> 
> (Updated 2010-11-21 11:41:39)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Currently, each test is responsible for defining there verbose and debug settings, this makes it difficult to debug problems.  This patch moves them to a global setting across all tests.  Rather then using 'core set verbose / debug' to set the level, we now use the asterisk.conf [options] section.  Additionally, these values are still override-able by passing ast_conf_options.
> 
> To accomplish this, new logic was added that will '#include' a file which stores the settings.  The file naming will be defined as:  <asterisk module>.<file category>.conf.inc For example: Configuration variables in asterisk.options.conf.inc would be loaded into asterisk.conf [options] category.
> 
> I've also updated logger.conf to this format.
> 
> Finally, I've moved the configs directory out of tests/ to a top level directory.
> 
> 
> Diffs
> -----
> 
>   asterisk/trunk/README.txt 898 
>   asterisk/trunk/configs/asterisk.options.conf.inc PRE-CREATION 
>   asterisk/trunk/configs/branch-1.4/logger.conf PRE-CREATION 
>   asterisk/trunk/configs/branch-1.6.2/logger.conf PRE-CREATION 
>   asterisk/trunk/configs/logger.conf PRE-CREATION 
>   asterisk/trunk/configs/logger.general.conf.inc PRE-CREATION 
>   asterisk/trunk/configs/logger.logfiles.conf.inc PRE-CREATION 
>   asterisk/trunk/lib/python/asterisk/asterisk.py 898 
>   asterisk/trunk/tests/blind-transfer-parkingtimeout/run-test 898 
>   asterisk/trunk/tests/callparking/run-test 898 
>   asterisk/trunk/tests/directed_pickup/run-test 898 
>   asterisk/trunk/tests/fastagi/channel-status/run-test 898 
>   asterisk/trunk/tests/fastagi/connect/run-test 898 
>   asterisk/trunk/tests/fastagi/control-stream-file/run-test 898 
>   asterisk/trunk/tests/fastagi/database/run-test 898 
>   asterisk/trunk/tests/fastagi/execute/run-test 898 
>   asterisk/trunk/tests/fastagi/get-data/run-test 898 
>   asterisk/trunk/tests/fastagi/hangup/run-test 898 
>   asterisk/trunk/tests/fastagi/record-file/run-test 898 
>   asterisk/trunk/tests/fastagi/say-alpha/run-test 898 
>   asterisk/trunk/tests/fastagi/say-date/run-test 898 
>   asterisk/trunk/tests/fastagi/say-datetime/run-test 898 
>   asterisk/trunk/tests/fastagi/say-digits/run-test 898 
>   asterisk/trunk/tests/fastagi/say-number/run-test 898 
>   asterisk/trunk/tests/fastagi/say-phonetic/run-test 898 
>   asterisk/trunk/tests/fastagi/say-time/run-test 898 
>   asterisk/trunk/tests/fastagi/stream-file/run-test 898 
>   asterisk/trunk/tests/fastagi/wait-for-digit/run-test 898 
>   asterisk/trunk/tests/feature_attended_transfer/run-test 898 
>   asterisk/trunk/tests/feature_blonde_transfer/run-test 898 
>   asterisk/trunk/tests/iax2/basic-call/run-test 898 
>   asterisk/trunk/tests/manager/login/run-test 898 
>   asterisk/trunk/tests/mixmonitor/run-test 898 
>   asterisk/trunk/tests/mixmonitor_audiohook_inherit/run-test 898 
>   asterisk/trunk/tests/one-step-parking/run-test 898 
> 
> Diff: https://reviewboard.asterisk.org/r/1026/diff
> 
> 
> Testing
> -------
> 
> All tests pass on local box.
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.digium.com/pipermail/asterisk-dev/attachments/20101122/1ac340e8/attachment-0001.htm