<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1026/">https://reviewboard.asterisk.org/r/1026/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 21st, 2010, 12:16 a.m., <b>Paul Belanger</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/1026/diff/2/?file=13117#file13117line358" style="color: black; font-weight: bold; text-decoration: underline;">asterisk/lib/python/asterisk/asterisk.py</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">def __gen_ast_conf(self, ast_conf, dir_cat, ast_conf_options):</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">358</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> f.write("#include \"%s/asterisk.options.conf.inc\"\n" %</pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">359</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> (self.astetcdir))</pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Not sure if this is a bug or what, but a full path must be use for asterisk.conf otherwise Asterisk will not find the file to be #included.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It's not a bug. Asterisk doesn't know what the configuration directory is supposed to be until after it has finished parsing asterisk.conf.</pre>
<br />
<p>- Russell</p>
<br />
<p>On November 21st, 2010, 11:41 a.m., Paul Belanger wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Paul Belanger.</div>
<p style="color: grey;"><i>Updated 2010-11-21 11:41:39</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Currently, each test is responsible for defining there verbose and debug settings, this makes it difficult to debug problems. This patch moves them to a global setting across all tests. Rather then using 'core set verbose / debug' to set the level, we now use the asterisk.conf [options] section. Additionally, these values are still override-able by passing ast_conf_options.
To accomplish this, new logic was added that will '#include' a file which stores the settings. The file naming will be defined as: <asterisk module>.<file category>.conf.inc For example: Configuration variables in asterisk.options.conf.inc would be loaded into asterisk.conf [options] category.
I've also updated logger.conf to this format.
Finally, I've moved the configs directory out of tests/ to a top level directory.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">All tests pass on local box.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>asterisk/trunk/README.txt <span style="color: grey">(898)</span></li>
<li>asterisk/trunk/configs/asterisk.options.conf.inc <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/configs/branch-1.4/logger.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/configs/branch-1.6.2/logger.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/configs/logger.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/configs/logger.general.conf.inc <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/configs/logger.logfiles.conf.inc <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/lib/python/asterisk/asterisk.py <span style="color: grey">(898)</span></li>
<li>asterisk/trunk/tests/blind-transfer-parkingtimeout/run-test <span style="color: grey">(898)</span></li>
<li>asterisk/trunk/tests/callparking/run-test <span style="color: grey">(898)</span></li>
<li>asterisk/trunk/tests/directed_pickup/run-test <span style="color: grey">(898)</span></li>
<li>asterisk/trunk/tests/fastagi/channel-status/run-test <span style="color: grey">(898)</span></li>
<li>asterisk/trunk/tests/fastagi/connect/run-test <span style="color: grey">(898)</span></li>
<li>asterisk/trunk/tests/fastagi/control-stream-file/run-test <span style="color: grey">(898)</span></li>
<li>asterisk/trunk/tests/fastagi/database/run-test <span style="color: grey">(898)</span></li>
<li>asterisk/trunk/tests/fastagi/execute/run-test <span style="color: grey">(898)</span></li>
<li>asterisk/trunk/tests/fastagi/get-data/run-test <span style="color: grey">(898)</span></li>
<li>asterisk/trunk/tests/fastagi/hangup/run-test <span style="color: grey">(898)</span></li>
<li>asterisk/trunk/tests/fastagi/record-file/run-test <span style="color: grey">(898)</span></li>
<li>asterisk/trunk/tests/fastagi/say-alpha/run-test <span style="color: grey">(898)</span></li>
<li>asterisk/trunk/tests/fastagi/say-date/run-test <span style="color: grey">(898)</span></li>
<li>asterisk/trunk/tests/fastagi/say-datetime/run-test <span style="color: grey">(898)</span></li>
<li>asterisk/trunk/tests/fastagi/say-digits/run-test <span style="color: grey">(898)</span></li>
<li>asterisk/trunk/tests/fastagi/say-number/run-test <span style="color: grey">(898)</span></li>
<li>asterisk/trunk/tests/fastagi/say-phonetic/run-test <span style="color: grey">(898)</span></li>
<li>asterisk/trunk/tests/fastagi/say-time/run-test <span style="color: grey">(898)</span></li>
<li>asterisk/trunk/tests/fastagi/stream-file/run-test <span style="color: grey">(898)</span></li>
<li>asterisk/trunk/tests/fastagi/wait-for-digit/run-test <span style="color: grey">(898)</span></li>
<li>asterisk/trunk/tests/feature_attended_transfer/run-test <span style="color: grey">(898)</span></li>
<li>asterisk/trunk/tests/feature_blonde_transfer/run-test <span style="color: grey">(898)</span></li>
<li>asterisk/trunk/tests/iax2/basic-call/run-test <span style="color: grey">(898)</span></li>
<li>asterisk/trunk/tests/manager/login/run-test <span style="color: grey">(898)</span></li>
<li>asterisk/trunk/tests/mixmonitor/run-test <span style="color: grey">(898)</span></li>
<li>asterisk/trunk/tests/mixmonitor_audiohook_inherit/run-test <span style="color: grey">(898)</span></li>
<li>asterisk/trunk/tests/one-step-parking/run-test <span style="color: grey">(898)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1026/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>