[asterisk-dev] [Code Review] Announce to user that they have been muted when muting is done via AMI

kobaz reviewboard at asterisk.org
Sat Nov 20 15:03:19 CST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1010/
-----------------------------------------------------------

(Updated 2010-11-20 15:03:19.564165)


Review request for Asterisk Developers.


Changes
-------

Updated MeetMeMute/MeetMeUnMute to optionally announce to user if they have been muted or unmuted.

I'm not sure why yet, but the new destructor ast_conf_user_ao2_destructor() that I added, is not being called.  This is my first foray into ao2, so I'm not sure how the destructors work.  Is there an async garbage collector that will eventually run?


Summary
-------

Announce to user that they have been muted when muting is done via AMI

When a user does a *1, they hear 'you have been (un)muted'
When a mute or unmute command is sent over the ami, the user hears no mute notification.

I'm not sure if my method of handling stopping/resuming music on hold is correct.


Diffs (updated)
-----

  trunk/apps/app_meetme.c 295123 

Diff: https://reviewboard.asterisk.org/r/1010/diff


Testing
-------

AMI MeetmeMute
AMI MeetmeUnmute


Thanks,

kobaz

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.digium.com/pipermail/asterisk-dev/attachments/20101120/199e9229/attachment.htm 


More information about the asterisk-dev mailing list