[asterisk-dev] [Code Review] Announce to user that they have been muted when muting is done via AMI

[reviewboard at asterisk.org]

> On 2010-11-16 00:39:15, kobaz wrote:
> > trunk/apps/app_meetme.c, lines 4751-4753
> > <https://reviewboard.asterisk.org/r/1010/diff/1/?file=12912#file12912line4751>
> >
> >     Is this the correct music class to start back up?
> 
> Russell Bryant wrote:
>     The musicclass is an option to MeetMe(), so you'll need to use that as the argument, not the channel musicclass.  However, it might not be available to you in this piece of code.  Look at all the other uses of conf_start_moh().  They appear to be using the optargs[] array directly.
>     
>     To get the right musicclass, you may need to save it in the conference user struct.

Okay, that's what I thought.  And I did notice that it was not available in the meetmemute function.  And you answered my next question was... where do I put it.  Thanks.


- kobaz


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1010/#review2913
-----------------------------------------------------------


On 2010-11-15 16:24:17, kobaz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1010/
> -----------------------------------------------------------
> 
> (Updated 2010-11-15 16:24:17)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Announce to user that they have been muted when muting is done via AMI
> 
> When a user does a *1, they hear 'you have been (un)muted'
> When a mute or unmute command is sent over the ami, the user hears no mute notification.
> 
> I'm not sure if my method of handling stopping/resuming music on hold is correct.
> 
> 
> Diffs
> -----
> 
>   trunk/apps/app_meetme.c 295123 
> 
> Diff: https://reviewboard.asterisk.org/r/1010/diff
> 
> 
> Testing
> -------
> 
> AMI MeetmeMute
> AMI MeetmeUnmute
> 
> 
> Thanks,
> 
> kobaz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.digium.com/pipermail/asterisk-dev/attachments/20101116/d29d58e4/attachment.htm