[asterisk-dev] [Code Review] MeetMe option for caching join/leave announce names

[reviewboard at asterisk.org]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1009/
-----------------------------------------------------------

(Updated 2010-11-17 15:53:09.615728)


Review request for Asterisk Developers.


Changes
-------

I've included all of the suggestions from Russell.  I'm still unsure if the logic at 2473 (138 in the diff) is the right way to do things.


Summary
-------

I was looking for a feature to cache the recording of your name for when you use options I or i in meetme that announces a users name on entering and exiting a conference, this way users wouldn’t have to do this every time. My goal with this is to auto-join members to a conference without them having to enter a pin or say their name, yet still have their name announced to the conference.  Instead of caching the file we use the users voicemail greet file from their mailbox, if the file does not exist then we unset the new flag in meetme (h), and it falls back to the old switches of i or I depending what you'd prefer for recording review/noreview.

Usage is like this: MeetMe(PIN,h(${CALLERID(num)}@default))


Diffs (updated)
-----

  /trunk/apps/app_meetme.c 294817 

Diff: https://reviewboard.asterisk.org/r/1009/diff


Testing
-------

I've tested with the users voicemail greet file there, and not there, with a combination of flags i or I being set.  
I tested that i and I work properly without h set to ensure nothing i've added broke the old functionality.

I tested using the following commands with the greeting file being in the users mailbox, and the greeting file not being there.
MeetMe(1,ih(${CALLERID(num)}@default))
MeetMe(1,Ih(${CALLERID(num)}@default))
MeetMe(1,i)
MeetMe(1,I)


Thanks,

Andrew

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.digium.com/pipermail/asterisk-dev/attachments/20101117/146fdf13/attachment.htm