[asterisk-dev] [Code Review] MeetMe option for caching join/leave announce names

[reviewboard at asterisk.org]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1009/#review2915
-----------------------------------------------------------



/trunk/apps/app_meetme.c
<https://reviewboard.asterisk.org/r/1009/#comment6137>

    The documentation needs to include the parameter to h().  See others that take an argument for examples.
    
    I would suggesting the following wording for the documentation:
    
    Announce when a user is joining or leaving the conference.  Use the voicemail greeting as the announcement.  If the i or I options are set, the application will fall back to those options if no voicemail greeting can be found.



/trunk/apps/app_meetme.c
<https://reviewboard.asterisk.org/r/1009/#comment6139>

    This line of code can be simplified a bit, something like:
    
    ast_test_flag64(confflgs, CONFFLAG_ | CONFFLAG_ | CONFFLAG_ );



/trunk/apps/app_meetme.c
<https://reviewboard.asterisk.org/r/1009/#comment6140>

    same flag check simplification here



/trunk/apps/app_meetme.c
<https://reviewboard.asterisk.org/r/1009/#comment6141>

    remove space after (, add space after comma, add space before {



/trunk/apps/app_meetme.c
<https://reviewboard.asterisk.org/r/1009/#comment6142>

    Do you really want to do the rest of the stuff after this if mailbox is invalid?



/trunk/apps/app_meetme.c
<https://reviewboard.asterisk.org/r/1009/#comment6143>

    spaces after commas



/trunk/apps/app_meetme.c
<https://reviewboard.asterisk.org/r/1009/#comment6144>

    } else {



/trunk/apps/app_meetme.c
<https://reviewboard.asterisk.org/r/1009/#comment6145>

    res = 0;


- Russell


On 2010-11-12 17:03:42, Andrew Parisio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1009/
> -----------------------------------------------------------
> 
> (Updated 2010-11-12 17:03:42)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> I was looking for a feature to cache the recording of your name for when you use options I or i in meetme that announces a users name on entering and exiting a conference, this way users wouldn’t have to do this every time. My goal with this is to auto-join members to a conference without them having to enter a pin or say their name, yet still have their name announced to the conference.  Instead of caching the file we use the users voicemail greet file from their mailbox, if the file does not exist then we unset the new flag in meetme (h), and it falls back to the old switches of i or I depending what you'd prefer for recording review/noreview.
> 
> Usage is like this: MeetMe(PIN,h(${CALLERID(num)}@default))
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_meetme.c 294817 
> 
> Diff: https://reviewboard.asterisk.org/r/1009/diff
> 
> 
> Testing
> -------
> 
> I've tested with the users voicemail greet file there, and not there, with a combination of flags i or I being set.  
> I tested that i and I work properly without h set to ensure nothing i've added broke the old functionality.
> 
> I tested using the following commands with the greeting file being in the users mailbox, and the greeting file not being there.
> MeetMe(1,ih(${CALLERID(num)}@default))
> MeetMe(1,Ih(${CALLERID(num)}@default))
> MeetMe(1,i)
> MeetMe(1,I)
> 
> 
> Thanks,
> 
> Andrew
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.digium.com/pipermail/asterisk-dev/attachments/20101116/2b605c09/attachment-0001.htm