[asterisk-dev] [Code Review] Call parking and retrieval test

Tilghman Lesher tlesher at digium.com
Tue Nov 2 12:04:12 CDT 2010



> On 2010-11-02 11:43:44, Matthew Nicholson wrote:
> > /asterisk/trunk/trunk/tests/callparking_retrieval/run-test, lines 36-44
> > <https://reviewboard.asterisk.org/r/994/diff/1/?file=12797#file12797line36>
> >
> >     You should do "core stop gracefully"  before calling stop now; "stop gracefully" in 1.4.

I don't think that should make a difference.  The reason is, at this point, the test has already succeeded or failed, and we don't need the calls to exit normally.  If the calls are still up, the shutdown will simply be delayed until either the 'stop now' or the call ends.


> On 2010-11-02 11:43:44, Matthew Nicholson wrote:
> > /asterisk/trunk/trunk/tests/callparking_retrieval/run-test, line 76
> > <https://reviewboard.asterisk.org/r/994/diff/1/?file=12797#file12797line76>
> >
> >     It might be helpful to also generate a custom logger.conf that enables full logging.

I've actually been doing that, but because the test doesn't need anything (debug, verbose) other than the default (warning, error, notice), I haven't committed that file into the repository.


> On 2010-11-02 11:43:44, Matthew Nicholson wrote:
> > /asterisk/trunk/trunk/tests/callparking_retrieval/run-test, lines 87-88
> > <https://reviewboard.asterisk.org/r/994/diff/1/?file=12797#file12797line87>
> >
> >     You could also do asterisk -rx "core waitfullybooted" here.

Ah, since it returns 1 or 0, that should reduce the wait time.  Excellent suggestion.


> On 2010-11-02 11:43:44, Matthew Nicholson wrote:
> > /asterisk/trunk/trunk/tests/callparking_retrieval/run-test, lines 107-115
> > <https://reviewboard.asterisk.org/r/994/diff/1/?file=12797#file12797line107>
> >
> >     When I run the test it fails here. It appears this check fails seeing 7 lines in 1.6.2 instead of 5 lines.  I think this is because 'sleep 3' does not give enough time for the transfer process to finish playing the parking lot number and hang up the call.  Increasing the sleep time here appears to make the test pass.

Ah HAH!  That works.  Thank you.


- Tilghman


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/994/#review2874
-----------------------------------------------------------


On 2010-11-01 12:21:38, Tilghman Lesher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/994/
> -----------------------------------------------------------
> 
> (Updated 2010-11-01 12:21:38)
> 
> 
> Review request for Asterisk Developers and Russell Bryant.
> 
> 
> Summary
> -------
> 
> This is a change for 1.6.2.  The patch exists, but I am attempting to work up a test to verify that it functions correctly, as a regression test.  However, the test is failing.  I think there may be something wrong with my test criteria, so I am posting it in an effort to get others to help figure this out.
> 
> 
> This addresses bug 16757.
>     https://issues.asterisk.org/view.php?id=16757
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/trunk/tests/callparking_retrieval/run-test PRE-CREATION 
>   /asterisk/trunk/trunk/tests/callparking_retrieval/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/trunk/tests/callparking_retrieval/userA/extensions.conf PRE-CREATION 
>   /asterisk/trunk/trunk/tests/callparking_retrieval/userA/iax.conf PRE-CREATION 
>   /asterisk/trunk/trunk/tests/callparking_retrieval/userB/extensions.conf PRE-CREATION 
>   /asterisk/trunk/trunk/tests/callparking_retrieval/userB/iax.conf PRE-CREATION 
>   /asterisk/trunk/trunk/tests/callparking_retrieval/userC/extensions.conf PRE-CREATION 
>   /asterisk/trunk/trunk/tests/callparking_retrieval/userC/features.conf PRE-CREATION 
>   /asterisk/trunk/trunk/tests/callparking_retrieval/userC/iax.conf PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/994/diff
> 
> 
> Testing
> -------
> 
> This IS a test.
> 
> 
> Thanks,
> 
> Tilghman
> 
>




More information about the asterisk-dev mailing list