[asterisk-dev] [Code Review] Call parking and retrieval test

[Matthew Nicholson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/994/#review2874
-----------------------------------------------------------



/asterisk/trunk/trunk/tests/callparking_retrieval/run-test
<https://reviewboard.asterisk.org/r/994/#comment6067>

    You should do "core stop gracefully"  before calling stop now; "stop gracefully" in 1.4.



/asterisk/trunk/trunk/tests/callparking_retrieval/run-test
<https://reviewboard.asterisk.org/r/994/#comment6069>

    It might be helpful to also generate a custom logger.conf that enables full logging.



/asterisk/trunk/trunk/tests/callparking_retrieval/run-test
<https://reviewboard.asterisk.org/r/994/#comment6068>

    You could also do asterisk -rx "core waitfullybooted" here.



/asterisk/trunk/trunk/tests/callparking_retrieval/run-test
<https://reviewboard.asterisk.org/r/994/#comment6070>

    When I run the test it fails here. It appears this check fails seeing 7 lines in 1.6.2 instead of 5 lines.  I think this is because 'sleep 3' does not give enough time for the transfer process to finish playing the parking lot number and hang up the call.  Increasing the sleep time here appears to make the test pass.


- Matthew


On 2010-11-01 12:21:38, Tilghman Lesher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/994/
> -----------------------------------------------------------
> 
> (Updated 2010-11-01 12:21:38)
> 
> 
> Review request for Asterisk Developers and Russell Bryant.
> 
> 
> Summary
> -------
> 
> This is a change for 1.6.2.  The patch exists, but I am attempting to work up a test to verify that it functions correctly, as a regression test.  However, the test is failing.  I think there may be something wrong with my test criteria, so I am posting it in an effort to get others to help figure this out.
> 
> 
> This addresses bug 16757.
>     https://issues.asterisk.org/view.php?id=16757
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/trunk/tests/callparking_retrieval/run-test PRE-CREATION 
>   /asterisk/trunk/trunk/tests/callparking_retrieval/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/trunk/tests/callparking_retrieval/userA/extensions.conf PRE-CREATION 
>   /asterisk/trunk/trunk/tests/callparking_retrieval/userA/iax.conf PRE-CREATION 
>   /asterisk/trunk/trunk/tests/callparking_retrieval/userB/extensions.conf PRE-CREATION 
>   /asterisk/trunk/trunk/tests/callparking_retrieval/userB/iax.conf PRE-CREATION 
>   /asterisk/trunk/trunk/tests/callparking_retrieval/userC/extensions.conf PRE-CREATION 
>   /asterisk/trunk/trunk/tests/callparking_retrieval/userC/features.conf PRE-CREATION 
>   /asterisk/trunk/trunk/tests/callparking_retrieval/userC/iax.conf PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/994/diff
> 
> 
> Testing
> -------
> 
> This IS a test.
> 
> 
> Thanks,
> 
> Tilghman
> 
>