[asterisk-dev] rhino dahdi drivers and DAHDI_VER

[Tzafrir Cohen]

On Mon, Nov 01, 2010 at 07:26:20AM -0500, Shaun Ruffell wrote:
> On 11/01/2010 07:10 AM, Tzafrir Cohen wrote:

> > The way it is used in the drivers of Rhino is something such as:
> > 
> >   #if DAHDI_VER >= KERNEL_VERSION(2,4,0)
> 
> Not that it really concerns me, but this doesn't make any sense to me.
> I didn't know the preprocessor does comparisons between strings
> ("SVN-branch-2.3-r9455") and integers ("#define KERNEL_VERSION(a,b,c)
> (((a) << 16) + ((b) << 8) + (c))").
> 
> Something sounds broken there.  My guess is that the Makefile is just
> overwriting include/dahdi/version.h unless there is also another patch
> for the Makefile or build_tools/make_version_h.

This also breaks with 2.2.1.1 and 2.3.0.1 .

-- 
               Tzafrir Cohen
icq#16849755              jabber:tzafrir.cohen at xorcom.com
+972-50-7952406           mailto:tzafrir.cohen at xorcom.com
http://www.xorcom.com  iax:guest at local.xorcom.com/tzafrir