[asterisk-dev] [Code Review] CLI command 'manager show settings'

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/630/#review1958
-----------------------------------------------------------

Ship it!


One last nitpick, then good to go


/trunk/main/manager.c
<https://reviewboard.asterisk.org/r/630/#comment4189>

    You don't need to set this to NULL.  It will be that way automagically.
    
    Also, the '*' should be by the variable name, not the type based on coding guidelines.


- Russell


On 2010-04-29 10:08:35, pabelanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/630/
> -----------------------------------------------------------
> 
> (Updated 2010-04-29 10:08:35)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch adds 'manager show settings' CLI command.  Most of the logic was used from chan_sip.c.
> 
> 
> This addresses bug 16343.
>     https://issues.asterisk.org/view.php?id=16343
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/cli.h 260048 
>   /trunk/include/asterisk/manager.h 260048 
>   /trunk/main/manager.c 260048 
> 
> Diff: https://reviewboard.asterisk.org/r/630/diff
> 
> 
> Testing
> -------
> 
> Local developers and testing boxes.
> 
> 
> Thanks,
> 
> pabelanger
> 
>