[asterisk-dev] [Code Review] CLI command 'manager show settings'

[Russell Bryant]

> On 2010-05-04 16:17:58, Russell Bryant wrote:
> > /trunk/main/manager.c, lines 5742-5743
> > <https://reviewboard.asterisk.org/r/630/diff/4/?file=9832#file9832line5742>
> >
> >     You added the manager_channelvars variable in this patch, but this is the only place you use it.  What was the intention?

Nevermind, I can't read.


- Russell


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/630/#review1956
-----------------------------------------------------------


On 2010-04-29 10:08:35, pabelanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/630/
> -----------------------------------------------------------
> 
> (Updated 2010-04-29 10:08:35)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch adds 'manager show settings' CLI command.  Most of the logic was used from chan_sip.c.
> 
> 
> This addresses bug 16343.
>     https://issues.asterisk.org/view.php?id=16343
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/cli.h 260048 
>   /trunk/include/asterisk/manager.h 260048 
>   /trunk/main/manager.c 260048 
> 
> Diff: https://reviewboard.asterisk.org/r/630/diff
> 
> 
> Testing
> -------
> 
> Local developers and testing boxes.
> 
> 
> Thanks,
> 
> pabelanger
> 
>