[asterisk-dev] [Code Review] Creation of Local channel best practices documentation.

[Jared Smith]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/534/#review1614
-----------------------------------------------------------


In general, I think this is a great document to help beginners learn more about local channels.  I don't know that it really gets into "best practices" all that much, but that's OK.  I've added a few comments to various sections where it might be improved.


https://origsvn.digium.com/svn/asterisk/trunk/doc/localchannels-bestpractices.txt
<https://reviewboard.asterisk.org/r/534/#comment3613>

    I think it might be more instructive to say "A local channel a pseudo-channel used to treat an extension in the dialplan as if it were an external device.  To dial an extension use the chan_local channel driver." 
    
    I think that's a bit clearer than saying it's simply a loop-back.  (Loop-back has other meanings in the world of telecom, and we want to clarify things for the reader, not confuse them.)



https://origsvn.digium.com/svn/asterisk/trunk/doc/localchannels-bestpractices.txt
<https://reviewboard.asterisk.org/r/534/#comment3614>

    This example might be a bit deep for someone trying to learn about local channels... it presupposes that they already understand the AstDB, which might be a bit much to assume.



https://origsvn.digium.com/svn/asterisk/trunk/doc/localchannels-bestpractices.txt
<https://reviewboard.asterisk.org/r/534/#comment3615>

    What about the other modifiers to the Local channel, besides the /n?  I know there is a /j to enable the jitter-buffer on the local channel, and it seems like there was another option recently added in trunk as well.


- Jared


On 2010-03-01 14:11:37, Leif Madsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/534/
> -----------------------------------------------------------
> 
> (Updated 2010-03-01 14:11:37)
> 
> 
> Review request for Asterisk Developers, Russell Bryant, Mark Michelson, Jared Smith, and Tilghman Lesher.
> 
> 
> Summary
> -------
> 
> This document is a draft version of some documentation for Local channels that I've created. I'm not 100% sure exactly where I want it to reside. Should this replace localchannel.txt? Should this be an addition to the current README-SERIOUSLY.bestpractices.txt document? Your suggestions and comments are welcome!
> 
> Any ideas for additional information is also welcome!
> 
> 
> Diffs
> -----
> 
>   https://origsvn.digium.com/svn/asterisk/trunk/doc/localchannels-bestpractices.txt PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/534/diff
> 
> 
> Testing
> -------
> 
> I've reviewed the documentation and created the dialplans in my PBX and did some testing, so hopefully all the examples are working for people.
> 
> 
> Thanks,
> 
> Leif
> 
>