[asterisk-dev] [Code Review] Honor --with-${library}=/path directory when using AST_EXT_TOOL_CHECK

Kevin Fleming kpfleming at digium.com
Wed Jun 23 15:49:37 CDT 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/739/#review2259
-----------------------------------------------------------

Ship it!


- Kevin


On 2010-06-23 15:32:43, Terry Wilson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/739/
> -----------------------------------------------------------
> 
> (Updated 2010-06-23 15:32:43)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Libraries that rely on pkgconfig scripts to handle cflags/ldflags arguments currently only look for the ${library}-config script in the path. If you want to compile against a different copy and pass --with-${library}=/path, you end up getting the wrong ${library}-config script. This change makes AST_EXT_TOOL_CHECK first look for the tool in /path/bin.
> 
> 
> This addresses bug 16991.
>     https://issues.asterisk.org/view.php?id=16991
> 
> 
> Diffs
> -----
> 
>   /trunk/autoconf/ast_ext_tool_check.m4 272124 
> 
> Diff: https://reviewboard.asterisk.org/r/739/diff
> 
> 
> Testing
> -------
> 
> Verified that existing AST_EXT_TOOL_CHECK libraries seem to be unaffected and that passing --with-netsnmp=/tmp/netsnmp resulted in it finding the /tmp/netsnmp/bin/netsnmp-config script.
> 
> 
> Thanks,
> 
> Terry
> 
>




More information about the asterisk-dev mailing list