[asterisk-dev] [Code Review] Honor --with-${library}=/path directory when using AST_EXT_TOOL_CHECK

Terry Wilson twilson at digium.com
Wed Jun 23 15:32:43 CDT 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/739/
-----------------------------------------------------------

(Updated 2010-06-23 15:32:43.845277)


Review request for Asterisk Developers.


Changes
-------

Change to AC_CHECK_PATH, and remove hacky resetting of CONFIG_$1. Tested by moving /usr/bin/net-snmp-config to /tmp/bin and running ./configure --with-netsnmp=/tmp. config.log had CONFIG_NETSNMP='/tmp/bin/net-snmp-config'


Summary
-------

Libraries that rely on pkgconfig scripts to handle cflags/ldflags arguments currently only look for the ${library}-config script in the path. If you want to compile against a different copy and pass --with-${library}=/path, you end up getting the wrong ${library}-config script. This change makes AST_EXT_TOOL_CHECK first look for the tool in /path/bin.


This addresses bug 16991.
    https://issues.asterisk.org/view.php?id=16991


Diffs (updated)
-----

  /trunk/autoconf/ast_ext_tool_check.m4 272124 

Diff: https://reviewboard.asterisk.org/r/739/diff


Testing
-------

Verified that existing AST_EXT_TOOL_CHECK libraries seem to be unaffected and that passing --with-netsnmp=/tmp/netsnmp resulted in it finding the /tmp/netsnmp/bin/netsnmp-config script.


Thanks,

Terry




More information about the asterisk-dev mailing list