[asterisk-dev] [Code Review] Implement arbitrary-length read and write data extraction from files, using byte-based and line-based offsets

[Tilghman Lesher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/737/
-----------------------------------------------------------

(Updated 2010-06-23 00:29:50.253698)


Review request for Asterisk Developers.


Changes
-------

Kill cruddy red spots.


Summary
-------

Currently, the FILE() function only works with small files, reading from them, based upon a possible byte-offset and byte-length.  This patch allows files to additionally be written, by replacing arbitrary length sections with input text.  Additionally, the decision was made by the reporter to support line-based offsets and lengths, in addition to the existing byte-offsets and lengths.


This addresses bug 16461.
    https://issues.asterisk.org/view.php?id=16461


Diffs (updated)
-----

  /trunk/funcs/func_env.c 272085 
  /trunk/tests/test_func_file.c PRE-CREATION 

Diff: https://reviewboard.asterisk.org/r/737/diff


Testing
-------

A fairly exhaustive unit test module has been written.  The code passes all tests.


Thanks,

Tilghman