[asterisk-dev] [Code Review] Improve realtime queue logging

[paul.belanger at polybeacon.com]

> On 2010-06-16 16:04:18, pabelanger wrote:
> > Thanks for the patch.  We will also need documentation for the table structure.
> 
> coolmig wrote:
>     An example of table structure is in the additional info of the bug. Because there's a fifth data column, the table structure would look like this for PostgreSQL:
>     
>     
>     CREATE TABLE "queue_log" (
>       "id" SERIAL,
>       "eventdate" TIMESTAMP WITH TIME ZONE DEFAULT now() NOT NULL,
>       "cdr_uniqueid" VARCHAR(32) DEFAULT ''::character varying NOT NULL,
>       "queuename" VARCHAR(32) DEFAULT ''::character varying NOT NULL,
>       "agent" VARCHAR(32) DEFAULT ''::character varying NOT NULL,
>       "event" VARCHAR(32) DEFAULT ''::character varying NOT NULL,
>       "data1" VARCHAR(100) DEFAULT ''::character varying NOT NULL,
>       "data2" VARCHAR(100) DEFAULT ''::character varying NOT NULL,
>       "data3" VARCHAR(100) DEFAULT ''::character varying NOT NULL,
>       "data4" VARCHAR(100) DEFAULT ''::character varying NOT NULL,
>       "data5" VARCHAR(100) DEFAULT ''::character varying NOT NULL,
>       CONSTRAINT "queue_log_pkey" PRIMARY KEY("id")
>     ) WITHOUT OIDS;
>

This still needs to be documented with asterisk some place.  Check out the existing .tex files for an example.


- pabelanger


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/731/#review2217
-----------------------------------------------------------


On 2010-06-16 16:01:07, pabelanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/731/
> -----------------------------------------------------------
> 
> (Updated 2010-06-16 16:01:07)
> 
> 
> Review request for Asterisk Developers and coolmig.
> 
> 
> Summary
> -------
> 
> Posing this review, coolmig seems to be having problems.
> 
> ---
> I was playing with the RT queue log functionality, and found this limitations:
> 
> 1. If you choose RT queue logging, you won't have the traditional plain text file file log. This file is very useful for backup purposes.
> 2. The column 'data' stores all the parameters separated by '|', which is not the best way to store it.
> 
> I managed to program a patch which overcomes this limitations, and works this way:
> 
> 1. If you enable RT queue logging, the queue log will still be logged in the plain text file, so you have some backup in case of some database disaster.
> 2. The parameters are now "exploded", and put in separate fields for each one. The only thing here is that this code must be changed in case that some queue log event delivers more than 4 parameters (the only event that gives 4 parameters is TRANSFER).
> 3. The calldate is now stored just like the CDR, with a full datetime.
> 4. The plain text file is left as is, for compatibility purposes.
> 5. The fieldnames on the table changed a little. 
> 
> 
> This addresses bug 17082.
>     https://issues.asterisk.org/view.php?id=17082
> 
> 
> Diffs
> -----
> 
>   /trunk/main/logger.c 270975 
> 
> Diff: https://reviewboard.asterisk.org/r/731/diff
> 
> 
> Testing
> -------
> 
> coolmig
> 
> 
> Thanks,
> 
> pabelanger
> 
>