[asterisk-dev] [Code Review] Improve realtime queue logging

[paul.belanger at polybeacon.com]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/731/#review2217
-----------------------------------------------------------


Thanks for the patch.  We will also need documentation for the table structure.


/trunk/main/logger.c
<https://reviewboard.asterisk.org/r/731/#comment4721>

    Red blob.



/trunk/main/logger.c
<https://reviewboard.asterisk.org/r/731/#comment4722>

    spacing after ,



/trunk/main/logger.c
<https://reviewboard.asterisk.org/r/731/#comment4723>

    Another red blob


- pabelanger


On 2010-06-16 16:01:07, pabelanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/731/
> -----------------------------------------------------------
> 
> (Updated 2010-06-16 16:01:07)
> 
> 
> Review request for Asterisk Developers and coolmig.
> 
> 
> Summary
> -------
> 
> Posing this review, coolmig seems to be having problems.
> 
> ---
> I was playing with the RT queue log functionality, and found this limitations:
> 
> 1. If you choose RT queue logging, you won't have the traditional plain text file file log. This file is very useful for backup purposes.
> 2. The column 'data' stores all the parameters separated by '|', which is not the best way to store it.
> 
> I managed to program a patch which overcomes this limitations, and works this way:
> 
> 1. If you enable RT queue logging, the queue log will still be logged in the plain text file, so you have some backup in case of some database disaster.
> 2. The parameters are now "exploded", and put in separate fields for each one. The only thing here is that this code must be changed in case that some queue log event delivers more than 4 parameters (the only event that gives 4 parameters is TRANSFER).
> 3. The calldate is now stored just like the CDR, with a full datetime.
> 4. The plain text file is left as is, for compatibility purposes.
> 5. The fieldnames on the table changed a little. 
> 
> 
> This addresses bug 17082.
>     https://issues.asterisk.org/view.php?id=17082
> 
> 
> Diffs
> -----
> 
>   /trunk/main/logger.c 270975 
> 
> Diff: https://reviewboard.asterisk.org/r/731/diff
> 
> 
> Testing
> -------
> 
> coolmig
> 
> 
> Thanks,
> 
> pabelanger
> 
>