[asterisk-dev] [Code Review] Extend the max number of callgroups/pickupgroups

[Jeff Peeler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/466/#review2239
-----------------------------------------------------------


All I see left to correct are spacing issues.


/trunk/main/channel.c
<https://reviewboard.asterisk.org/r/466/#comment4742>

    spacing



/trunk/main/channel.c
<https://reviewboard.asterisk.org/r/466/#comment4743>

    spacing



/trunk/main/channel.c
<https://reviewboard.asterisk.org/r/466/#comment4744>

    spacing



/trunk/main/channel.c
<https://reviewboard.asterisk.org/r/466/#comment4741>

    spacing


- Jeff


On 2010-06-20 13:50:35, raarts wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/466/
> -----------------------------------------------------------
> 
> (Updated 2010-06-20 13:50:35)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Currently the number of callgroups/pickupgroups is limited to 63, because the variable type that holds the group bits is a long long.
> 
> Here's a patch that extends this variable to an arbitrary-length (determined at compile time) int array. It currently sets the max number of groups to 1024.
> It implements this for all channels, but I only tested SIP and DAHDI.
> 
> Some people might object to implementing this as an array of ints, because it introduces a loop. But I think call pickups are not done often enough for this to become a problem.
> 
> See https://issues.asterisk.org/view.php?id=16640
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_dumpchan.c 271517 
>   /trunk/channels/chan_agent.c 271517 
>   /trunk/channels/chan_dahdi.c 271517 
>   /trunk/channels/chan_gtalk.c 271517 
>   /trunk/channels/chan_jingle.c 271517 
>   /trunk/channels/chan_mgcp.c 271517 
>   /trunk/channels/chan_misdn.c 271517 
>   /trunk/channels/chan_sip.c 271517 
>   /trunk/channels/chan_skinny.c 271517 
>   /trunk/channels/chan_unistim.c 271517 
>   /trunk/channels/misdn_config.c 271517 
>   /trunk/doc/asterisk-mib.txt 271517 
>   /trunk/funcs/func_channel.c 271517 
>   /trunk/include/asterisk/channel.h 271517 
>   /trunk/main/channel.c 271517 
>   /trunk/main/cli.c 271517 
>   /trunk/main/features.c 271517 
>   /trunk/res/snmp/agent.c 271517 
> 
> Diff: https://reviewboard.asterisk.org/r/466/diff
> 
> 
> Testing
> -------
> 
> This patch has been in our asterisk 1.2 for 3 years now without problems. I ported it over to 1.6.2 and tested it there. The patch uploaded here is against trunk which is currently being tested by a colleague of mine, but they are all basically the same patch. 
> 
> 
> Thanks,
> 
> raarts
> 
>