[asterisk-dev] [Code Review] SIP from-header is parsed twice

[Nick Lewis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/701/
-----------------------------------------------------------

(Updated 2010-06-22 08:57:10.563117)


Review request for Asterisk Developers and David Vossel.


Changes
-------

Changed function name to set_pvt_source and added documentation


Summary
-------

The handlers in chan_sip.c for invite and subscription requests parse the from-header twice. The first time is in check_user_full and the second time is in get_destination. This change removes the parsing from these functions and does it beforehand (with an abnf compliant parser)


This addresses bug 16897.
    https://issues.asterisk.org/view.php?id=16897


Diffs (updated)
-----

  trunk/channels/chan_sip.c 268968 
  trunk/channels/sip/reqresp_parser.c 268968 

Diff: https://reviewboard.asterisk.org/r/701/diff


Testing
-------

Compiles, runs, passes associated unit test. CID field appears correct in sip show channel 


Thanks,

Nick