[asterisk-dev] unneeded line removal? [was: Re: [svn-commits]jpeeler: branch 1.4 r260434 - /branches/1.4/channels/chan_dahdi.c]

[Jeff Peeler]

On Mon, Jun 14, 2010 at 4:27 AM, Alec Davis <sivad.a at paradise.net.nz> wrote:

> DAHDI Version: SVN-branch-2.2-r8678 Echo Canceller:
>
> OK with 1.6.2 SVN-branch-1.6.2-r270080M
> Fails with 1.4 SVN-branch-1.4-r269960M
>
> Adding line back as suggested fixes it for 1.4
>
> Diff below to fix 1.4
> Index: channels/chan_dahdi.c
> ===================================================================
> --- channels/chan_dahdi.c       (revision 270075)
> +++ channels/chan_dahdi.c       (working copy)
> @@ -4532,6 +4532,7 @@
>                                         p->subs[index].f.frametype =
> AST_FRAME_CONTROL;
>                                        p->subs[index].f.subclass =
> AST_CONTROL_ANSWER;
>                                        /* Make sure it stops ringing */
> +                                       dahdi_set_hook(p->subs[index].dfd,
> DAHDI_OFFHOOK);
>                                        p->subs[SUB_REAL].needringing = 0;
>                                        ast_log(LOG_DEBUG, "channel %d
> answered\n", p->channel);
>                                        if (p->cidspill) {
>
>
>
> Alec


Yes, this was a mistake. Thanks for putting it back.

--
Jeff Peeler
Digium, Inc. | Software Developer
445 Jan Davis Drive NW - Huntsville, AL 35806 - USA
Check us out at www.digium.com & www.asterisk.org
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.digium.com/pipermail/asterisk-dev/attachments/20100615/c77e4e54/attachment.htm