[asterisk-dev] unneeded line removal? [was: Re: [svn-commits]jpeeler: branch 1.4 r260434 - /branches/1.4/channels/chan_dahdi.c]

[Alec Davis]

DAHDI Version: SVN-branch-2.2-r8678 Echo Canceller:

OK with 1.6.2 SVN-branch-1.6.2-r270080M
Fails with 1.4 SVN-branch-1.4-r269960M

Adding line back as suggested fixes it for 1.4

Diff below to fix 1.4
Index: channels/chan_dahdi.c
===================================================================
--- channels/chan_dahdi.c       (revision 270075)
+++ channels/chan_dahdi.c       (working copy)
@@ -4532,6 +4532,7 @@
                                        p->subs[index].f.frametype =
AST_FRAME_CONTROL;
                                        p->subs[index].f.subclass =
AST_CONTROL_ANSWER;
                                        /* Make sure it stops ringing */
+                                       dahdi_set_hook(p->subs[index].dfd,
DAHDI_OFFHOOK);
                                        p->subs[SUB_REAL].needringing = 0;
                                        ast_log(LOG_DEBUG, "channel %d
answered\n", p->channel);
                                        if (p->cidspill) {



Alec

-----Original Message-----
From: asterisk-dev-bounces at lists.digium.com
[mailto:asterisk-dev-bounces at lists.digium.com] On Behalf Of Tzafrir Cohen
Sent: Monday, 14 June 2010 5:41 p.m.
To: asterisk-dev at lists.digium.com
Subject: Re: [asterisk-dev] unneeded line removal? [was: Re:
[svn-commits]jpeeler: branch 1.4 r260434 -
/branches/1.4/channels/chan_dahdi.c]

On Mon, Jun 14, 2010 at 09:57:24AM +1200, Alec Davis wrote:
> I've heard this continual clicking 'ringing cadence' on an FXS port 
> during a call, but only with Asterisk 1.4 Branch. Hardware DIGIUM TDM800P.
> 
> Asterisk 1.6.2 SVN Branch and Asterisk Trunk were fine.
> 
> I didn't change the version of DAHDI while going between versions, but 
> which version of DAHDI 2.2-Branch, 2.3-Branch or trunk, I'd have to check.

It's also with FXS ports of our hardware. Some bisecting tracked it to that
specific change.

-- 
               Tzafrir Cohen
icq#16849755              jabber:tzafrir.cohen at xorcom.com
+972-50-7952406           mailto:tzafrir.cohen at xorcom.com
http://www.xorcom.com  iax:guest at local.xorcom.com/tzafrir

--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev