[asterisk-dev] [Code Review] SIP: peer matching by callbackextension

Olle E. Johansson oej at edvina.net
Tue Jun 15 08:59:11 CDT 2010


15 jun 2010 kl. 15.14 skrev Nick Lewis:

> 
> 
>> On 2009-10-02 14:47:44, Olle E Johansson wrote:
>>> I still think we should think very carefully and work on design before we commit either this or my peermatching stuff. I do not recommend merging this at this time.
>>> 
>>> (As expressed earlier on the asterisk-dev mailinglist)
>>> /O
>> 
>> David Vossel wrote:
>>    If you don't have any immediate plans to work on a new peer matching algorithm how do you feel about this patch being committed?  I know its not a pretty solution, but its simple and addresses the issue at hand.  If a new algorithm is implemented in the future, I doubt this patch will add any complexity to it's integration.
> 
> I think 8 months is long enough to wait for comments on something as simple as matching the registered extension to the peer that registered it. May I request that you take Russell's comments and commit.
> 
My peer matching code has been waiting for the new architecture even longer... So you're not alone. I have tons of patches that no one has bothered with looking at or discussing... If we are going to do anything, let's wait until after we've frozen 1.8 to get time to experiment.

/O


More information about the asterisk-dev mailing list