[asterisk-dev] [Code Review] chan_sip: Make the session-timers 'require: timer' header an option

[Kevin P. Fleming]

On 06/10/2010 03:38 AM, Nick Lewis wrote:

> I think the modes and behaviour could be as follows:
> refuse: for outgoing calls do not add to supported-header; 
>         for incoming calls do not add to supported-header even if received with required-header

This one is a violation of the SIP RFCs, please do not implement it. If
an incoming Require header includes 'timer', and the UA does not wish to
support Session-Timer, the *only* recourse it has is to reply with a
'420 Bad Extension'.

> accept: for outgoing calls do not add to supported-header but retry with it added to supported-header if a required-header rejection is received;
>         for incoming calls add to supported-header if received with supported-header
> (new)originate: for outgoing calls add to supported-header but not required-header;
>                 for incoming calls add to supported-header if received with supported-header
> require(oldorig): for outgoing calls add to supported-header and required-header; 
>                    for incoming calls add to supported-header and required-header even if not received with supported-header
> 
> If originate cannot be renamed for backward compatibility then the last two could be negotiate and originate

Otherwise this seems like a reasonable approach.

-- 
Kevin P. Fleming
Digium, Inc. | Director of Software Technologies
445 Jan Davis Drive NW - Huntsville, AL 35806 - USA
skype: kpfleming | jabber: kfleming at digium.com
Check us out at www.digium.com & www.asterisk.org