[asterisk-dev] [Code Review] non-root testsuite

[paul.belanger at polybeacon.com]

> On 2010-06-02 21:20:28, Russell Bryant wrote:
> > Do the asttest tests still work, too?

Working to resolve a segfault, but next patch will include updated paths for asttest.


> On 2010-06-02 21:20:28, Russell Bryant wrote:
> > asterisk/trunk/lib/python/asterisk/asterisk.py, lines 54-57
> > <https://reviewboard.asterisk.org/r/686/diff/1/?file=10496#file10496line54>
> >
> >     I'm certainly ok with adding the new path in there, but let's leave /etc/asterisk in there as the 2nd place it checks.

Fixed.


> On 2010-06-02 21:20:28, Russell Bryant wrote:
> > asterisk/trunk/runtests.py, line 231
> > <https://reviewboard.asterisk.org/r/686/diff/1/?file=10497#file10497line231>
> >
> >     If we're going to sandbox it like this, I wonder if it makes sense to just rm -rf the destination instead of using the uninstall-all target, to _really_ make sure it's clean.

Fixed.


- pabelanger


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/686/#review2137
-----------------------------------------------------------


On 2010-06-02 20:04:15, pabelanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/686/
> -----------------------------------------------------------
> 
> (Updated 2010-06-02 20:04:15)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Version 2 of non-root testsuite.  Base install directory for Asterisk is now /tmp/asterisk-base.
> 
> User MUST have permission to create sockets for sipp. 
> 
> 
> Diffs
> -----
> 
>   asterisk/trunk/lib/python/asterisk/asterisk.py 331 
>   asterisk/trunk/runtests.py 331 
>   asterisk/trunk/tests/example/run-test 331 
> 
> Diff: https://reviewboard.asterisk.org/r/686/diff
> 
> 
> Testing
> -------
> 
> Local testing as non-root users.
> 
> 
> Thanks,
> 
> pabelanger
> 
>