[asterisk-dev] [Code Review] non-root testsuite
Russell Bryant
russell at digium.com
Wed Jun 2 21:20:28 CDT 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/686/#review2137
-----------------------------------------------------------
Do the asttest tests still work, too?
asterisk/trunk/lib/python/asterisk/asterisk.py
<https://reviewboard.asterisk.org/r/686/#comment4534>
I'm certainly ok with adding the new path in there, but let's leave /etc/asterisk in there as the 2nd place it checks.
asterisk/trunk/runtests.py
<https://reviewboard.asterisk.org/r/686/#comment4533>
If we're going to sandbox it like this, I wonder if it makes sense to just rm -rf the destination instead of using the uninstall-all target, to _really_ make sure it's clean.
- Russell
On 2010-06-02 20:04:15, pabelanger wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/686/
> -----------------------------------------------------------
>
> (Updated 2010-06-02 20:04:15)
>
>
> Review request for Asterisk Developers.
>
>
> Summary
> -------
>
> Version 2 of non-root testsuite. Base install directory for Asterisk is now /tmp/asterisk-base.
>
> User MUST have permission to create sockets for sipp.
>
>
> Diffs
> -----
>
> asterisk/trunk/lib/python/asterisk/asterisk.py 331
> asterisk/trunk/runtests.py 331
> asterisk/trunk/tests/example/run-test 331
>
> Diff: https://reviewboard.asterisk.org/r/686/diff
>
>
> Testing
> -------
>
> Local testing as non-root users.
>
>
> Thanks,
>
> pabelanger
>
>
More information about the asterisk-dev
mailing list