[asterisk-dev] [Code Review] Convert res_musiconhold to use generic timing interface

Sean Bright sean.bright at gmail.com
Fri Jul 30 16:26:51 CDT 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/826/
-----------------------------------------------------------

(Updated 2010-07-30 16:26:51.143862)


Review request for Asterisk Developers and Russell Bryant.


Changes
-------

Updated diff


Summary
-------

This patch intends to remove res_musiconhold's dependency on DAHDI.  I feel like the conversion was a bit naive, but it works here.


This addresses bug 17726.
    https://issues.asterisk.org/view.php?id=17726


Diffs (updated)
-----

  /trunk/res/res_musiconhold.c 280623 

Diff: https://reviewboard.asterisk.org/r/826/diff


Testing
-------

Compiles and I can send a caller into MusicOnHold() and everything sounds fine.  Only tested with res_timing_dahdi.so, however.


Thanks,

Sean




More information about the asterisk-dev mailing list