[asterisk-dev] [Code Review] Convert res_musiconhold to use generic timing interface

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/826/#review2510
-----------------------------------------------------------



/trunk/res/res_musiconhold.c
<https://reviewboard.asterisk.org/r/826/#comment5534>

    I don't think any other usage of the timing API does a read() on the fd and expects it to block like this.  I would rather see this changed to be consistent with other timing API usage.  Other places poll() on the fd, and when poll() indicates input is available, you should call ast_timer_ack() instead of read().



/trunk/res/res_musiconhold.c
<https://reviewboard.asterisk.org/r/826/#comment5535>

    I don't think 50 is right.  I believe 25 is what is equivalent to the old code.


- Russell


On 2010-07-30 15:09:07, Sean Bright wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/826/
> -----------------------------------------------------------
> 
> (Updated 2010-07-30 15:09:07)
> 
> 
> Review request for Asterisk Developers and Russell Bryant.
> 
> 
> Summary
> -------
> 
> This patch intends to remove res_musiconhold's dependency on DAHDI.  I feel like the conversion was a bit naive, but it works here.
> 
> 
> This addresses bug 17726.
>     https://issues.asterisk.org/view.php?id=17726
> 
> 
> Diffs
> -----
> 
>   /trunk/res/res_musiconhold.c 280623 
> 
> Diff: https://reviewboard.asterisk.org/r/826/diff
> 
> 
> Testing
> -------
> 
> Compiles and I can send a caller into MusicOnHold() and everything sounds fine.  Only tested with res_timing_dahdi.so, however.
> 
> 
> Thanks,
> 
> Sean
> 
>